Skip to content

bpo-32429: Abort compilation on outdated Modules/Setup file. #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JulienPalard wants to merge 1 commit into from
Closed

bpo-32429: Abort compilation on outdated Modules/Setup file. #5015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,10 @@ Modules/Setup: $(srcdir)/Modules/Setup.dist
echo "check to make sure you have all the updates you"; \
echo "need in your Modules/Setup file."; \
echo "Usually, copying Modules/Setup.dist to Modules/Setup will work."; \
echo "Or if you want to keep your modifications, touch Modules/Setup"; \
Copy link
Copy Markdown
Contributor

@xdegaye xdegaye Dec 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Modules/Setup.dist has been changed as for example by 7d895ac in September 2016, touching Modules/Setup is not sufficient. I suggest to remove that line.

echo "to skip this warning."; \
echo "-----------------------------------------------"; \
false; \
fi

Programs/_testembed: Programs/_testembed.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY)
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Build/2017-12-26-23-22-37.bpo-32429.yfKLwE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Build will now fail when Module/Setup is out of date. Previously a warning
was displayed but was invisible due to make verbosity, sometimes giving a
non-working Python as a result, like in https://bugs.python.org/issue32335.