bpo-32454: socket closefd by tiran · Pull Request #5048 · python/cpython

tiran · 2017-12-30T09:42:05Z

Add close(fd) function to the socket module

Signed-off-by: Christian Heimes [email protected]

NOTE The PR also documents the previously undocumented socket.close function.

https://bugs.python.org/issue32454

eryksun · 2017-12-30T11:27:55Z

I think this should be !CHECK_ERRNO(ECONNRESET), or use GET_SOCK_ERROR instead of errno.

Winsock is an OS library, so it can't use errno of a particular C runtime library. It uses Windows API [WSA]GetLastError and [WSA]SetLastError.

Good point!

pitrou · 2017-12-30T11:57:19Z

You should add a versionadded too.

The socket.dup() function exists since 2.6 at least. It just hasn't been documented yet.

pitrou · 2017-12-30T11:57:43Z

Is there already a test for dup()?

Ping on this question.

No, there is no test. I don't have time to write a test case, Would you like me to drop the documentation for dup?

pitrou · 2017-12-30T11:57:59Z

If it always does, then how about a assertRaises?

assertRaises in the finally block may mask an error in the try block.

Normally, Python 3 would display the exception chain.

tiran · 2018-01-26T19:44:37Z

@eryksun @pitrou I'd like to land this feature in 3.7.

Add close(fd) function to the socket module Signed-off-by: Christian Heimes <[email protected]>

tiran · 2018-01-26T21:42:16Z

I removed the documentation for dup(fd) from this PR.

.. function:: dup(fd)
 
   Duplicate a socket file descriptor. This is like :func:`os.dup`, but for
   sockets. On some platforms (most noticeable Windows) :func:`os.dup`
   does not work for socket file descriptors.

pitrou

Thank you Christian!

bedevere-bot · 2018-01-27T08:54:15Z

@tiran: Please replace # with GH- in the commit message next time. Thanks!

tiran · 2018-01-27T08:54:46Z

thx @pitrou

tiran added the type-feature A feature request or enhancement label Dec 30, 2017

the-knights-who-say-ni added the CLA signed label Dec 30, 2017

bedevere-bot added the awaiting merge label Dec 30, 2017

eryksun reviewed Dec 30, 2017

View reviewed changes

pitrou reviewed Dec 30, 2017

View reviewed changes

tiran force-pushed the socket_closefd branch from e8578d4 to df760d2 Compare January 14, 2018 15:47

tiran mentioned this pull request Jan 16, 2018

bpo-28134: Auto-detect socket values from file descriptor #1349

Merged

bpo-32454: socket closefd

2b317dc

Add close(fd) function to the socket module Signed-off-by: Christian Heimes <[email protected]>

tiran force-pushed the socket_closefd branch from df760d2 to 2b317dc Compare January 26, 2018 21:41

pitrou approved these changes Jan 27, 2018

View reviewed changes

tiran merged commit d0e31b9 into python:master Jan 27, 2018

bedevere-bot removed the awaiting merge label Jan 27, 2018

tiran deleted the socket_closefd branch January 27, 2018 08:54

Uh oh!

Conversation

tiran commented Dec 30, 2017 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tiran commented Jan 26, 2018

Uh oh!

tiran commented Jan 26, 2018

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jan 27, 2018

Uh oh!

tiran commented Jan 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tiran commented Dec 30, 2017 •

edited by bedevere-bot

Loading