bpo-32102 Add "capture_output=True" option to subprocess.run#5149
Merged
gpshead merged 6 commits intopython:masterfrom Jan 30, 2018
Merged
bpo-32102 Add "capture_output=True" option to subprocess.run#5149gpshead merged 6 commits intopython:masterfrom
gpshead merged 6 commits intopython:masterfrom
Conversation
Member
|
Looks like there's an incorrect reference to issue 32248 in the description. |
Contributor
Author
|
Whoops, you're right. Not sure how I did that. 32102 is the correct issue number. I've fixed the description and reference. However, my branch name is still incorrect. Does that matter? If so I can close this PR and open a new one with a better branch name. |
Member
|
The branch name doesn't technically matter, so that's entirely up to you. Thanks for fixing things. |
this keeps the old description of *text* and makes the *capture_output* mention its own sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
capture_outputparameter tosubprocess.run, as described in issue 32102.I have been pleased to see the
subprocessgetting easier to use over the last few releases, and was happy to see the idea for replacingsubprocess.run(..., stdin=subprocess.PIPE, stdout=subprocess.PIPE)with something friendlier had already been proposed.https://bugs.python.org/issue32102