bpo-32549: Compile OpenSSL 1.1.0 on Travis CI#5180
Merged
tiran merged 1 commit intopython:masterfrom Jan 16, 2018
Merged
Conversation
31cac11 to
0857d9c
Compare
1a2dc69 to
88ae122
Compare
Use an improved version of multissl test helper to compile a local copy of OpenSSL 1.1.0g. Signed-off-by: Christian Heimes <[email protected]>
Member
Author
|
This PR is a prerequisite for several of my ssl improvements. Do you agree with my approach? I'm going to remove the hak ss soon as Travis has OpenSSL 1.0.2+ in a base image. Also see travis-ci/travis-ci#9069 |
brettcannon
approved these changes
Jan 16, 2018
Member
brettcannon
left a comment
There was a problem hiding this comment.
LGTM; whatever works to unblock you is basically fine by me. 😄
Member
Author
|
@brettcannon thanks! I'm also changing travis CI settings from monthly to daily cron job on master. This will populate the cache tonight. Further runs should reuse pre-cached openssl builds. |
Member
Author
|
s/change/add/g We didn't have cronjob runs at all. I misunderstood the UI. |
pitrou
reviewed
Jan 16, 2018
| exit | ||
| fi | ||
| if [ "${TESTING}" != "docs" ]; then | ||
| # clang complains about unused-parameter a lot, redirect stderr |
Member
There was a problem hiding this comment.
At some point, perhaps the before_script should be factored out instead of duplicating all its contents?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an improved version of multissl test helper to compile a local copy
of OpenSSL 1.1.0g.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue32549