Skip to content

bpo-32248: Fix Git attributes of test_importlib data files#5209

Merged
vstinner merged 1 commit intopython:masterfrom
vstinner:test_importlib_gitattributes
Jan 17, 2018
Merged

bpo-32248: Fix Git attributes of test_importlib data files#5209
vstinner merged 1 commit intopython:masterfrom
vstinner:test_importlib_gitattributes

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Jan 16, 2018

Make sure that Git checks out data files with Unix line
ending on Windows as well.

https://bugs.python.org/issue32248

bpo-32248: Make sure that Git checks out data files with Unix line
ending on Windows as well.
Copy link
Copy Markdown
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner
Copy link
Copy Markdown
Member Author

FYI I tested manually that this PR fixes test_importlib on Windows.

I'm not sure that AppVeyor pass on other PR on master, without this fix.

@vstinner vstinner merged commit 44a70e9 into python:master Jan 17, 2018
@vstinner vstinner deleted the test_importlib_gitattributes branch January 17, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants