bpo-32248: Fix test_importlib.test_open()#5213
Merged
vstinner merged 1 commit intopython:masterfrom Jan 17, 2018
vstinner:importlib_open_binary
Merged
bpo-32248: Fix test_importlib.test_open()#5213vstinner merged 1 commit intopython:masterfrom vstinner:importlib_open_binary
vstinner merged 1 commit intopython:masterfrom
vstinner:importlib_open_binary
Conversation
Use the binary.file instead of utf-8.file to avoid issues with Unix newlines vs Windows newlines.
Member
Author
|
My .gitattributes fix (commit 44a70e9) was not enough. The test still fails on AMD64 Windows8.1 Non-Debug 3.x for example: http://buildbot.python.org/all/#/builders/12/builds/477 |
Member
Author
|
Hum, AppVeyor failed to download dependencies: I scheduled a new AppVeyor build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the binary.file instead of utf-8.file to avoid issues with
Unix newlines vs Windows newlines.
https://bugs.python.org/issue32248