Skip to content

bpo-32296: Make get_running_loop() another 4-5x faster#5277

Merged
1st1 merged 4 commits intopython:masterfrom
1st1:speedup_getrunning
Jan 23, 2018
Merged

bpo-32296: Make get_running_loop() another 4-5x faster#5277
1st1 merged 4 commits intopython:masterfrom
1st1:speedup_getrunning

Conversation

@1st1
Copy link
Copy Markdown
Member

@1st1 1st1 commented Jan 23, 2018 •
edited
Loading

Microbenchmark I used:

import asyncio
import time


async def main():
    g = asyncio.get_running_loop
    t = time.monotonic()
    for _ in range(10**6):
        g(); g(); g(); g(); g(); g(); g(); g()
        g(); g(); g(); g(); g(); g(); g(); g()
        g(); g(); g(); g(); g(); g(); g(); g()
        g(); g(); g(); g(); g(); g(); g(); g()
    print(f'total: {time.monotonic() - t:.3f}s')


asyncio.run(main())

https://bugs.python.org/issue32296

@1st1 1st1 added the skip news label Jan 23, 2018
@1st1 1st1 requested a review from asvetlov January 23, 2018 05:42
@njsmith
Copy link
Copy Markdown
Contributor

njsmith commented Jan 23, 2018

I take it you concluded that this was easier than fixing run_until_complete to work with storing the running loop in a ContextVar?

@1st1
Copy link
Copy Markdown
Member Author

1st1 commented Jan 23, 2018

I take it you concluded that this was easier than fixing run_until_complete to work with storing the running loop in a ContextVar?

I honestly have no idea how to do that with contextvars. This PR speeds things up because of:

  1. caching (similar to contextvars)
  2. avoiding boxing of integers and calling os.getpid(); getpid() is called directly.

80% of the speedup is (2).

asvetlov
asvetlov approved these changes Jan 23, 2018
View reviewed changes
Comment thread Modules/_asynciomodule.c Outdated
static PyObject* future_new_iter(PyObject *);
static inline int future_call_schedule_callbacks(FutureObj *);

static PyRunningLoopHolder *
Copy link
Copy Markdown
Contributor

@asvetlov asvetlov Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The declaration fits into single line I think. A space between PyRunningLoopHolder and * is not needed.

@1st1 1st1 merged commit 9d411c1 into python:master Jan 23, 2018
@1st1 1st1 deleted the speedup_getrunning branch January 23, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@1st1 @njsmith @asvetlov @the-knights-who-say-ni @bedevere-bot