Skip to content

bpo-32749: Make dbm.dumb databases more cosistent with other dbm databases.#5497

Merged
serhiy-storchaka merged 3 commits intopython:masterfrom
serhiy-storchaka:dbm-dumb-open
Feb 5, 2018
Merged

bpo-32749: Make dbm.dumb databases more cosistent with other dbm databases.#5497
serhiy-storchaka merged 3 commits intopython:masterfrom
serhiy-storchaka:dbm-dumb-open

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Feb 2, 2018

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Feb 2, 2018
Comment thread Lib/test/test_dbm_dumb.py Outdated
@@ -244,34 +244,27 @@ def test_eval(self):
def test_warn_on_ignored_flags(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test name is no longer accurate, should be something like test_raise_on_bad_flags

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@serhiy-storchaka serhiy-storchaka merged commit 6c85efa into python:master Feb 5, 2018
@bedevere-bot
Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@serhiy-storchaka serhiy-storchaka deleted the dbm-dumb-open branch February 5, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants