bpo-32819: Simplify and improve ssl.match_hostname#5620
Merged
tiran merged 1 commit intopython:masterfrom Feb 24, 2018
Merged
Conversation
fcac61c to
9b87c22
Compare
pitrou
reviewed
Feb 16, 2018
ssl.match_hostname() has been simplified and no longer depends on re and ipaddress module for wildcard and IP addresses. Error reporting for invalid wildcards has been improved. Signed-off-by: Christian Heimes <[email protected]>
9b87c22 to
dfeabcc
Compare
Member
Author
|
Thanks @pitrou ! I have fixed the typo and rebased the PR. |
pitrou
approved these changes
Feb 22, 2018
|
@tiran: Please replace |
Contributor
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 24, 2018
ssl.match_hostname() has been simplified and no longer depends on re and ipaddress module for wildcard and IP addresses. Error reporting for invalid wildcards has been improved. Signed-off-by: Christian Heimes <[email protected]> (cherry picked from commit aef1283) Co-authored-by: Christian Heimes <[email protected]>
|
GH-5847 is a backport of this pull request to the 3.7 branch. |
tiran
added a commit
that referenced
this pull request
Feb 24, 2018
…5847) ssl.match_hostname() has been simplified and no longer depends on re and ipaddress module for wildcard and IP addresses. Error reporting for invalid wildcards has been improved. Signed-off-by: Christian Heimes <[email protected]> (cherry picked from commit aef1283) Co-authored-by: Christian Heimes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl.match_hostname() has been simplified and no longer depends on re and
ipaddress module for wildcard and IP addresses. Error reporting for invalid
wildcards has been improved.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue32819