Skip to content

Fix typo in comment at the end of conditional block#5681

Merged
Mariatta merged 1 commit intopython:masterfrom
ngie-eign:fix-push-posixmodule-osx
Feb 14, 2018
Merged

Fix typo in comment at the end of conditional block#5681
Mariatta merged 1 commit intopython:masterfrom
ngie-eign:fix-push-posixmodule-osx

Conversation

@ngie-eign
Copy link
Copy Markdown
Contributor

@ngie-eign ngie-eign commented Feb 14, 2018

Signed-off-by: Enji Cooper [email protected]

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Feb 14, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta merged commit 7745ec4 into python:master Feb 14, 2018
@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Feb 14, 2018

Thanks @ngie-eign and congrats on your first contribution to CPython 🌮
This is trivial so I bypassed the CLA requirement for now. But please do sign it for your future contributions.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 14, 2018

Thanks @ngie-eign for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 14, 2018

Thanks @ngie-eign for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 14, 2018

Thanks @ngie-eign for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 14, 2018

GH-5686 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2018
@ngie-eign @miss-islington
Update comment in posixmodule.c (pythonGH-5681)
b02b18f 
A closing parentheses was missing.

Signed-off-by: Ngie Cooper <[email protected]>
(cherry picked from commit 7745ec4)

Co-authored-by: ngie-eign <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 14, 2018

GH-5687 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2018
@ngie-eign @miss-islington
Update comment in posixmodule.c (pythonGH-5681)
6b4a3ec 
A closing parentheses was missing.

Signed-off-by: Ngie Cooper <[email protected]>
(cherry picked from commit 7745ec4)

Co-authored-by: ngie-eign <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 14, 2018

GH-5688 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2018
@ngie-eign @miss-islington
Update comment in posixmodule.c (pythonGH-5681)
522aed9 
A closing parentheses was missing.

Signed-off-by: Ngie Cooper <[email protected]>
(cherry picked from commit 7745ec4)

Co-authored-by: ngie-eign <[email protected]>
miss-islington added a commit that referenced this pull request Feb 14, 2018
@miss-islington @ngie-eign
Update comment in posixmodule.c (GH-5681)
836b642 
A closing parentheses was missing.

Signed-off-by: Ngie Cooper <[email protected]>
(cherry picked from commit 7745ec4)

Co-authored-by: ngie-eign <[email protected]>
miss-islington added a commit that referenced this pull request Feb 14, 2018
@miss-islington @ngie-eign
Update comment in posixmodule.c (GH-5681)
f0616ce 
A closing parentheses was missing.

Signed-off-by: Ngie Cooper <[email protected]>
(cherry picked from commit 7745ec4)

Co-authored-by: ngie-eign <[email protected]>
miss-islington added a commit that referenced this pull request Feb 14, 2018
@miss-islington @ngie-eign
Update comment in posixmodule.c (GH-5681)
f62a9d4 
A closing parentheses was missing.

Signed-off-by: Ngie Cooper <[email protected]>
(cherry picked from commit 7745ec4)

Co-authored-by: ngie-eign <[email protected]>
@ngie-eign
Copy link
Copy Markdown
Contributor Author

ngie-eign commented Feb 15, 2018

@Mariatta: thank you for the note -- I'll definitely sign the CLA, since I plan on contributing more changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ngie-eign @the-knights-who-say-ni @Mariatta @miss-islington @bedevere-bot @serhiy-storchaka