bpo-33083 - math.factorial accepts non-integral Decimal instances#6149
bpo-33083 - math.factorial accepts non-integral Decimal instances#6149pablogsal merged 6 commits intopython:masterfrom
Conversation
| @@ -0,0 +1,3 @@ | |||
| math.factorial no longer accept arguments that are not int-like. A | |||
There was a problem hiding this comment.
Sorry for nit-picking a bit. But
"math.factorial no longer accepts arguments.." (accept -> accepts).
emmited -> emitted
taleinat
left a comment
There was a problem hiding this comment.
It was decided on the issue to avoid deprecating floats as part of this issue. Please undo the changes regarding deprecation of floats; though perhaps keep them stashed somewhere for future use...
| } | ||
| else{ | ||
| pyint_form = PyNumber_Index(arg); | ||
| if( pyint_form == NULL){ |
There was a problem hiding this comment.
Fix the spacing on this and the next line.
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @taleinat: please review the changes made to this pull request. |
taleinat
left a comment
There was a problem hiding this comment.
The NEWS entry no longer correctly reflects the changes made; please revise.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
|
I have made the requested changes; please review again. Thank you for the whitespace fix! |
|
Thanks for making the requested changes! @taleinat: please review the changes made to this pull request. |
a449b46 to
4b465a4
Compare
vstinner
left a comment
There was a problem hiding this comment.
LGTM, you can merge it @pablogsal ;-)
vstinner
left a comment
There was a problem hiding this comment.
LGTM. @pablogsal you can merge it.
…deprecation warning for floats
https://bugs.python.org/issue33083