Skip to content

[3.7] bpo-31639: Use threads in http.server module. (GH-5018)#6202

Merged
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-8bcfa02-3.7
Mar 23, 2018
Merged

[3.7] bpo-31639: Use threads in http.server module. (GH-5018)#6202
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-8bcfa02-3.7

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Mar 23, 2018 •
edited by bedevere-bot
Loading

(cherry picked from commit 8bcfa02)

Co-authored-by: Julien Palard [email protected]

https://bugs.python.org/issue31639

@JulienPalard @miss-islington
bpo-31639: Use threads in http.server module. (pythonGH-5018)
e41366c 
(cherry picked from commit 8bcfa02)

Co-authored-by: Julien Palard <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2018
Merged
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Mar 23, 2018

@JulienPalard: Backport status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Mar 23, 2018

@JulienPalard: Backport status check is done, and it's a success ✅ .

ned-deily
ned-deily requested changes Mar 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments for the 3.6 version of this PR (#6203).

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 23, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington miss-islington merged commit f8d2c3c into python:3.7 Mar 23, 2018
@miss-islington
Copy link
Copy Markdown
Contributor Author

miss-islington commented Mar 23, 2018

Thanks!

@miss-islington miss-islington deleted the backport-8bcfa02-3.7 branch March 23, 2018 20:31
@JulienPalard
Copy link
Copy Markdown
Member

JulienPalard commented Mar 23, 2018

@ned-deily Woops looks like your messages was not present on my page when I approved, I spotted it right after. I'm reading them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily requested changes

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @bedevere-bot @JulienPalard @ned-deily @the-knights-who-say-ni