bpo-33262: Deprecate passing None for s to shlex.split()#6514
bpo-33262: Deprecate passing None for s to shlex.split()#6514pganssle merged 6 commits intopython:masterfrom
s to shlex.split()#6514Conversation
This reads the string to split from standard input.
|
Thank you for your PR and your time. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add also an entry in the What's New document.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
|
@ZackerySpytz, please address @pganssle's comment. Thanks! |
|
@ZackerySpytz, this looks like it was close to being merged. Please take a look at the last code review. Thanks! |
pganssle
left a comment
There was a problem hiding this comment.
LGTM. I assume the test failures are unrelated? Happy to merge once we have them green.
|
Yes, the CI failures were unrelated (I see errors like |
|
Great, thanks @ZackerySpytz! |
|
@pganssle The issue seems to be solved. We can close the issue. |
https://bugs.python.org/issue33262