bpo-20104: Remove posix_spawn from 3.7#6794
Merged
gpshead merged 3 commits intopython:3.7from May 14, 2018
Merged
Conversation
3284174 to
c200683
Compare
Member
Author
|
CC: @gpshead |
c200683 to
a65ef05
Compare
gpshead
reviewed
May 14, 2018
Member
gpshead
left a comment
There was a problem hiding this comment.
this looks straight forward.
I suggest dropping the changes to aclocal.m4, configure.ac, configure, pyconfig.h.in that remove the check for the API. It is fine for us to leave the autoconf script in 3.7 testing for the posix_spawn function.
Member
|
@ned-deily - what would you like to see for a Misc/NEWS.d entry for this. os.posix_spawn appeared in some betas but we're removing it before rc1. document it as being removed again? or just remove all prior mentions of adding it? |
Member
|
err, wrong autocompleted. ned. sorry. :) @ned-deily :) |
and reference the removal from the old news entry where it was added.
We can keep the configure test for posix_spawn, we'll need it in the future and having it in pyconfig.h will be convenient in case any 3.7 extension module wants to use it.
Member
|
okay, i've undone the configure changes and done the news entries. just waiting for the various CI runs to complete (overloaded by the sprints) before merging. |
serhiy-storchaka
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue20104