Skip to content

bpo-33462: Add __reversed__ to dict and dict views#6827

Merged
methane merged 26 commits intopython:masterfrom
remilapeyre:master
Nov 6, 2018
Merged

bpo-33462: Add __reversed__ to dict and dict views#6827
methane merged 26 commits intopython:masterfrom
remilapeyre:master

Conversation

@remilapeyre
Copy link
Copy Markdown

@remilapeyre remilapeyre commented May 14, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented May 14, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@matrixise
Copy link
Copy Markdown
Member

matrixise commented May 14, 2018

@remilapeyre Thank you so much for your PR but could you rename your PR with this format: "bpo-NNNN: TITLE".

Thank you

@matrixise
Copy link
Copy Markdown
Member

matrixise commented May 14, 2018

and I forgot one thing, you need to have the CLA for a review. Thank you

@remilapeyre remilapeyre changed the title bpo-33462 - Add __reverse__ to dict bpo-33462: Add __reverse__ to dict May 14, 2018
@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented May 14, 2018

@matrixise Thanks I added my GH username on b.p.o so the CLA situation should now be resolved.

@remilapeyre remilapeyre requested a review from rhettinger as a code owner May 15, 2018 09:52
vstinner
vstinner reviewed May 17, 2018
View reviewed changes
Comment thread Objects/dictobject.c Outdated
Comment thread Objects/dictobject.c Outdated
@remilapeyre remilapeyre requested a review from a team as a code owner May 23, 2018 14:40
selik
selik reviewed May 23, 2018
View reviewed changes
Comment thread Lib/test/test_dict.py Outdated
selik
selik reviewed May 23, 2018
View reviewed changes
Comment thread Lib/test/test_enumerate.py Outdated
@selik
Copy link
Copy Markdown
Contributor

selik commented May 23, 2018

@remilapeyre There's a slight typo in the pull request title. It should be __reversed__ not __reverse__.

@remilapeyre remilapeyre changed the title bpo-33462: Add __reverse__ to dict bpo-33462: Add __reversed__ to dict May 24, 2018
@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented May 24, 2018

@selik I updated the tests, thanks.

methane
methane reviewed Jun 13, 2018
View reviewed changes
Comment thread Objects/dictobject.c
methane
methane reviewed Jun 13, 2018
View reviewed changes
Comment thread PC/python3.def Outdated
methane
methane reviewed Jun 13, 2018
View reviewed changes
Comment thread Objects/dictobject.c Outdated
methane
methane reviewed Jun 13, 2018
View reviewed changes
Comment thread Objects/dictobject.c Outdated
methane
methane reviewed Jun 13, 2018
View reviewed changes
Comment thread Objects/dictobject.c
methane
methane reviewed Sep 11, 2018
View reviewed changes
Comment thread Doc/library/stdtypes.rst
Comment thread Lib/test/test_dict.py Outdated
@methane
Copy link
Copy Markdown
Member

methane commented Sep 11, 2018

Excuse me, I don't have time to final review before merge in this month.

remilapeyre
remilapeyre commented Sep 11, 2018
View reviewed changes
Copy link
Copy Markdown
Author

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a problem, after all I can live with reversed(iter(d.values())). Thanks for your help so far.

@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented Oct 31, 2018

@methane Would the PR be acceptable with the two changes you asked for?

methane
methane reviewed Nov 1, 2018
View reviewed changes
Comment thread Doc/library/stdtypes.rst
methane
methane reviewed Nov 1, 2018
View reviewed changes
Comment thread Doc/library/stdtypes.rst Outdated
Rémi Lapeyre added 3 commits November 2, 2018 20:59
Remove sorted usage from dict's tests
9333e26 
Dictionaries are officialy sorted since Python 3.7 and sorted usage
in tests can now be removed as the order is deterministic.
Fix typo in dict documentation
05941f8
Remove dict.__reversed__ examples
c50dd93
methane
methane requested changes Nov 5, 2018
View reviewed changes
Comment thread Doc/library/stdtypes.rst Outdated
Comment thread Doc/library/stdtypes.rst Outdated
Comment thread Objects/dictobject.c Outdated
Comment thread Objects/dictobject.c Outdated
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 5, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented Nov 5, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 5, 2018

Thanks for making the requested changes!

@methane: please review the changes made to this pull request.

@methane
Copy link
Copy Markdown
Member

methane commented Nov 5, 2018

Please resolve conflict.

@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented Nov 5, 2018

@methane the conflicts should now be resolved

@methane methane merged commit 6531bf6 into python:master Nov 6, 2018
@anjakefala anjakefala mentioned this pull request Jun 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@merwok merwok merwok left review comments

@methane methane methane approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

+1 more reviewer

@selik selik selik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@remilapeyre @the-knights-who-say-ni @matrixise @selik @methane @merwok @bedevere-bot @vstinner @ned-deily