Skip to content

[3.7] bpo-33706: Fix pymain_parse_cmdline_impl() (GH-7283)#7284

Merged
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-58d1683-3.7
May 31, 2018
Merged

[3.7] bpo-33706: Fix pymain_parse_cmdline_impl() (GH-7283)#7284
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-58d1683-3.7

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented May 31, 2018

Fix a crash in Python initialization when parsing the command line
options.

Fix memcpy() size parameter: previously, we read one wchar_t after
the end of _PyOS_optarg. Moreover, don't copy the trailingg NUL
character: we write it manually anyway.

Thanks Christoph Gohlke for the bug report and the fix!
(cherry picked from commit 58d1683)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue33706

Fix a crash in Python initialization when parsing the command line
options.

Fix memcpy() size parameter: previously, we read one wchar_t after
the end of _PyOS_optarg. Moreover, don't copy the trailingg NUL
character: we write it manually anyway.

Thanks Christoph Gohlke for the bug report and the fix!
(cherry picked from commit 58d1683)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c6de46e into python:3.7 May 31, 2018
@miss-islington
Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-58d1683-3.7 branch May 31, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants