bpo-33606: improve logging performance when logger is disabled#7285
Merged
vsajip merged 1 commit intopython:masterfrom Jun 1, 2018
Merged
bpo-33606: improve logging performance when logger is disabled#7285vsajip merged 1 commit intopython:masterfrom
vsajip merged 1 commit intopython:masterfrom
Conversation
There is a check in `Logger.handle` to check whether the logger is disabled or not. However, for normal logging via `Logger.debug`, `Logger.info`, etc it could already be checked in `Logger.isEnabledFor()` to improve the performance when the logger is disabled.
vsajip
approved these changes
Jun 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a check in
Logger.handleto check whether the logger is disabled or not. However, for normal logging viaLogger.debug,Logger.info, etc it could already be checked inLogger.isEnabledFor()to improve the performance when the logger is disabled.https://bugs.python.org/issue33606