bpo-33873: Add warning when using less than 3 warmup runs in runtest.py.#7736
Merged
vstinner merged 4 commits intopython:masterfrom Jun 16, 2018
Merged
bpo-33873: Add warning when using less than 3 warmup runs in runtest.py.#7736vstinner merged 4 commits intopython:masterfrom
runtest.py.#7736vstinner merged 4 commits intopython:masterfrom
Conversation
runtest.py.runtest.py.
vstinner
requested changes
Jun 15, 2018
|
|
||
| output_on_failure = ns.verbose3 | ||
|
|
||
| if ns.huntrleaks: |
Member
There was a problem hiding this comment.
If you put the warning here, you get one warning per test file. It would be better to put it in Regrtest.runtest().
Member
Author
There was a problem hiding this comment.
My bad. I did not notice this because I usually only run one file.
| warmup, repetitions, _ = ns.huntrleaks | ||
| if warmup < 3: | ||
| msg = ("WARNING: Using less than 3 warmup repetitions can " | ||
| "give false positives!") |
Member
There was a problem hiding this comment.
Somewhere you should mention the option "--huntrleaks/-R".
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
Member
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner
reviewed
Jun 16, 2018
| if self.ns.huntrleaks: | ||
| warmup, repetitions, _ = self.ns.huntrleaks | ||
| if warmup < 3: | ||
| msg = ("WARNING: Runing tests with --huntrleaks/-R and less than " |
This was referenced Jun 26, 2018
vstinner
added a commit
that referenced
this pull request
Jun 26, 2018
* bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686) * Enhance also format_duration(): work on integers and rounds towards +infinity (math.ceil). * Write unit tests on format_duration() (cherry picked from commit 4ffe9c2) * bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) regrtest: Add warning when using less than 3 warmup runs like -R 1:3. (cherry picked from commit cac4fef) * bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters (GH-7735) Fix bug in `Lib/test/libregrtest/runtest.py` that makes running tests an extra time than the specified number of runs. Add check for invalid --huntrleaks/-R parameters. (cherry picked from commit 58ed730)
vstinner
added a commit
that referenced
this pull request
Jun 26, 2018
* bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686) * Enhance also format_duration(): work on integers and rounds towards +infinity (math.ceil). * Write unit tests on format_duration() (cherry picked from commit 4ffe9c2) * bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) regrtest: Add warning when using less than 3 warmup runs like -R 1:3. (cherry picked from commit cac4fef) * bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters (GH-7735) Fix bug in `Lib/test/libregrtest/runtest.py` that makes running tests an extra time than the specified number of runs. Add check for invalid --huntrleaks/-R parameters. (cherry picked from commit 58ed730)
vstinner
added a commit
that referenced
this pull request
Jun 26, 2018
* bpo-33718: regrtest: use format_duration() to display failed tests (GH-7686) * Enhance also format_duration(): work on integers and rounds towards +infinity (math.ceil). * Write unit tests on format_duration() (cherry picked from commit 4ffe9c2) * bpo-33873: regrtest: Add warning on -R 1:3 (GH-7736) regrtest: Add warning when using less than 3 warmup runs like -R 1:3. (cherry picked from commit cac4fef) * bpo-33873: Fix bug in `runtest.py` and add checks for invalid `-R` parameters (GH-7735) Fix bug in `Lib/test/libregrtest/runtest.py` that makes running tests an extra time than the specified number of runs. Add check for invalid --huntrleaks/-R parameters. (cherry picked from commit 58ed730) (cherry picked from commit d1f9481)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33873