bpo-33916: Fix bz2 and lzma init when called twice#7843
bpo-33916: Fix bz2 and lzma init when called twice#7843vstinner merged 1 commit intopython:masterfrom vstinner:lzma_init
Conversation
bz2, lzma: When Decompressor.__init__() is called twice, free the old lock to not leak memory.
|
PR #7822 change fixes more cases, but it's more difficult (and maybe too risky) to backport. I propose to first apply this change to all branches, then only apply PR #7822 to master: https://bugs.python.org/issue23224#msg320146 |
|
@vstinner I had already created a PR which fixes these problems (as I posted on the bug tracker). Also, your fix is incomplete: internal buffers are still leaked. |
|
This change is the minimum change to fix https://bugs.python.org/issue33916 to allow me to implement the detection of handle leaks on Windows: https://bugs.python.org/issue18174 |
Right. Please read my comments :-) |
|
Yes, I saw you just posted :). |
|
@serhiy-storchaka: Hello! What do you think of applying this fix to all branches, but then work on PR #7822 for a better fix in the master branch? |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-7871 is a backport of this pull request to the 3.7 branch. |
bz2, lzma: When Decompressor.__init__() is called twice, free the old lock to not leak memory. (cherry picked from commit 9b7cf75) Co-authored-by: Victor Stinner <[email protected]>
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-7872 is a backport of this pull request to the 3.6 branch. |
bz2, lzma: When Decompressor.__init__() is called twice, free the old lock to not leak memory. (cherry picked from commit 9b7cf75) Co-authored-by: Victor Stinner <[email protected]>
bz2, lzma: When Decompressor.init() is called twice, free the old
lock to not leak memory.
https://bugs.python.org/issue33916