Skip to content

bpo-34047: IDLE: fix mousewheel scrolling direction on macOS #8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taleinat merged 3 commits into from
Aug 10, 2018
Merged

bpo-34047: IDLE: fix mousewheel scrolling direction on macOS #8678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecb8a61
bpo-34047: IDLE: fix mousewheel scrolling direction on macOS
taleinat Aug 5, 2018
dfa0f46
bpo-34047: add NEWS entry
taleinat Aug 5, 2018
feea15a
Replace mousescroll, augment htest.
terryjreedy Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions Lib/idlelib/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,12 +457,19 @@ def handle_yview(self, event, *args):
return 'break'

def mousescroll(self, event):
"Handle scroll wheel."
up = {EventType.MouseWheel: event.delta >= 0 == darwin,
"""Handle scrollwheel event.

For wheel up, event.delta = 120*n on Windows, -1*n on darwin,
where n can be > 1 if one scrolls fast. Flicking the wheel
generates up to maybe 20 events with n up to 10 or more 1.
Macs use wheel down (delta = 1*n) to scroll up, so positive
delta means to scroll up on both systems.

X-11 sends Control-Button-4 event instead.
"""
up = {EventType.MouseWheel: event.delta > 0,
EventType.Button: event.num == 4}
lines = 5
if up[event.type]:
lines = -lines
lines = -5 if up[event.type] else 5
self.text.yview_scroll(lines, 'units')
return 'break'

Expand Down Expand Up @@ -1701,7 +1708,11 @@ def _editor_window(parent): # htest #
filename = None
macosx.setupApp(root, None)
edit = EditorWindow(root=root, filename=filename)
edit.text.bind("<<close-all-windows>>", edit.close_event)
text = edit.text
text['height'] = 10
for i in range(20):
text.insert('insert', ' '*i + str(i) + '\n')
# text.bind("<<close-all-windows>>", edit.close_event)
# Does not stop error, neither does following
# edit.text.bind("<<close-window>>", edit.close_event)

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2018-08-05-15-49-55.bpo-34047.LGKsIm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed mousewheel scrolling direction on macOS.