Skip to content

bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338)#8784

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:backport-76aa2c0-master
Sep 17, 2018
Merged

bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338)#8784
serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka:backport-76aa2c0-master

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Aug 16, 2018 •
edited by bedevere-bot
Loading

Improve wording based on @larryhastings' wording in #8338.

https://bugs.python.org/issue33216

@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir labels Aug 16, 2018
ericsnowcurrently
ericsnowcurrently approved these changes Aug 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(conditional approval)
If there's nothing different from what landed in 3.5 then LGTM. Otherwise please indicate what is different. Thanks!

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented Aug 16, 2018

Descriptions of opcodes CALL_FUNCTION* and MAKE_FUNCTION are completely different from 3.5, because opcodes are different. But I tried to use the style used by Larry. If old style in 3.5 was bad, it is very likely that the style in 3.6+ is bad too.

@ericsnowcurrently
Copy link
Copy Markdown
Member

ericsnowcurrently commented Aug 17, 2018

Okay, thanks for clarifying. The change looks good to me; definitely an improvement. :)

@serhiy-storchaka serhiy-storchaka merged commit 5e99b56 into python:master Sep 17, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 17, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2018
@serhiy-storchaka @miss-islington
bpo-33216: Improve the documentation for CALL_FUNCTION_* (pythonGH-8338…
63da323 
…) (pythonGH-8784)

(cherry picked from commit 5e99b56)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 17, 2018

GH-9354 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2018
@serhiy-storchaka @miss-islington
bpo-33216: Improve the documentation for CALL_FUNCTION_* (pythonGH-8338…
bdb06ec 
…) (pythonGH-8784)

(cherry picked from commit 5e99b56)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 17, 2018

GH-9355 is a backport of this pull request to the 3.6 branch.

@serhiy-storchaka serhiy-storchaka deleted the backport-76aa2c0-master branch September 17, 2018 12:16
miss-islington added a commit that referenced this pull request Sep 17, 2018
@miss-islington @serhiy-storchaka
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (G…
f8e34ee 
…H-8784)

(cherry picked from commit 5e99b56)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Sep 17, 2018
@miss-islington @serhiy-storchaka
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (G…
1e7193b 
…H-8784)

(cherry picked from commit 5e99b56)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @ericsnowcurrently @miss-islington @bedevere-bot @the-knights-who-say-ni @larryhastings