bpo-29979: rewrite cgi.parse_multipart()#990
Closed
PierreQuentel wants to merge 33 commits intopython:masterfrom
PierreQuentel:parse_multipart
Closed
bpo-29979: rewrite cgi.parse_multipart()#990PierreQuentel wants to merge 33 commits intopython:masterfrom PierreQuentel:parse_multipart
PierreQuentel wants to merge 33 commits intopython:masterfrom
PierreQuentel:parse_multipart
Conversation
…Match is present. Add tests.
… check that it's a valid HTTP date with timezone set to UTC.
…osecond=0) instead of int()
…format ; ignore ill-formed values in If-Modified-Since header.
…several methods ; add a test for Last-Modified header.
|
@PierreQuentel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @orsenthil and @collinw to be potential reviewers. |
Contributor
Author
|
Sorry, I'm not using the correct version of the Github master repo. I close this PR and will open another one soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pull Request simplifies the code of cgi.parse_multipart() by reusing the FieldStorage class, and makes it consistent with FieldStorage results : the values for non-file fields becomes a list of strings, instead of a list of bytes.