The four protocol-like ABCs outside of collections.abc inherit from ABC directly#13005
Merged
srittau merged 4 commits intopython:mainfrom Nov 16, 2024
Merged
The four protocol-like ABCs outside of collections.abc inherit from ABC directly#13005srittau merged 4 commits intopython:mainfrom
srittau merged 4 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Seems okay? If I'd realized this would work in the first place, I wouldn't have proposed changing the inheritance of os.PathLike. I guess I just assumed there was some deeper issue that prevented this. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
python/cpython#126706
#11269
Switching PathLike from abc.ABC to abc.ABCMeta wasn't accepted (reasonably so), so I'm wondering what happens to mypy-primer if we do this.