Feat/merge trains additional #2547#3381
Feat/merge trains additional #2547#3381isaac-philip wants to merge 1 commit intopython-gitlab:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3381 +/- ##
==========================================
+ Coverage 92.16% 95.77% +3.61%
==========================================
Files 100 100
Lines 6125 6152 +27
==========================================
+ Hits 5645 5892 +247
+ Misses 480 260 -220
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@JohnVillalovos kindly have a look for same set of changes with earlier MR rebased on latest. thanks. |
There was a problem hiding this comment.
Pull request overview
Adds support for GitLab’s merge train merge-request endpoints (MR status on merge train + adding an MR to a merge train) to python-gitlab, along with unit tests and docs, addressing issue #2547.
Changes:
- Extend
ProjectMergeTrainManagerto supportget()and add a nestedmerge_requestsmanager for merge train MR status/add-to-train endpoints. - Add unit tests covering merge train listing, MR status retrieval, and adding an MR to a merge train.
- Document the new merge train MR classes/managers and provide usage examples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
gitlab/v4/objects/merge_trains.py |
Adds merge train MR REST object + manager; enables get() on merge trains. |
gitlab/v4/objects/projects.py |
Adjusts import for merge trains manager (lint-sensitive). |
tests/unit/objects/test_merge_trains.py |
Adds fixtures and tests for new merge train MR endpoints. |
docs/gl_objects/merge_trains.rst |
Documents new merge train MR objects/managers and examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@JohnVillalovos appreciate the review, kindly check if it looks good now after review changes. any more suggestions also I would be happy to rectify sooner. thank you. |
Thanks. I will try to find time and motivation to review this. Hopefully this week. |
|
As a note. It would be nice if it was squashed down to maybe 1 commit? Less than 12 sounds like a good start. |
Signed-off-by: Isaac Philip <[email protected]>
|
@isaac-philip Now it is 13 commits. Let me know if you need help squashing |
b2e70cc to
f1b8827
Compare
|
Hello @JohnVillalovos , have made the change as requested for single commit, thanks. |
closes #2547