bpo-11822: Improve disassembly to show embedded code objects.#1155
bpo-11822: Improve disassembly to show embedded code objects.#1155serhiy-storchaka wants to merge 3 commits intopython:masterfrom
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @birkenfeld and @benjaminp to be potential reviewers. |
ncoghlan
left a comment
There was a problem hiding this comment.
Thanks for getting this RFE moving again!
I think there may be some usability and robustness problems with a simple all-or-nothing flag for the recursive behaviour, so I've posted that question back on the original issue: https://bugs.python.org/issue11822#msg291718
| if hasattr(x, 'co_code'): | ||
| print(file=file) | ||
| print("Disassembly of %r:" % (x,), file=file) | ||
| disassemble(x, file=file, recursive=True) |
There was a problem hiding this comment.
This has the potential to get very noisy if disassembling a whole module, so I've posted a design question back on the original issue: https://bugs.python.org/issue11822#msg291718
I'd prefer to keep that discussion on the issue tracker, so I won't duplicate it here.
|
As per the discussion at https://bugs.python.org/issue11822#msg291780, I still prefer the approach with the Link to Serhiy's PR with the |
|
Closed in favor of #1844. |
No description provided.