Skip to content

bpo-11822: Improve disassembly to show embedded code objects (limited depth).#1844

Merged
serhiy-storchaka merged 8 commits intopython:masterfrom
serhiy-storchaka:dis-recursive-limited
Jun 11, 2017
Merged

bpo-11822: Improve disassembly to show embedded code objects (limited depth).#1844
serhiy-storchaka merged 8 commits intopython:masterfrom
serhiy-storchaka:dis-recursive-limited

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

This is an alternate patch for bpo-11822. The depth of recursion is limited by the parameter depth.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 28, 2017
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion at https://bugs.python.org/issue11822#msg291780, if we go with this approach, the default should be None (to render the entire code tree), rather than 0.

@ncoghlan
Copy link
Copy Markdown
Contributor

The Appveyor failure doesn't look related - it's an issue with accessing a UNC path in the import tests.

@serhiy-storchaka serhiy-storchaka merged commit 1efbf92 into python:master Jun 11, 2017
@serhiy-storchaka serhiy-storchaka deleted the dis-recursive-limited branch June 11, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants