bpo-22640: Add silent mode to py_compile by nanjekyejoannah · Pull Request #12976 · python/cpython

nanjekyejoannah · 2019-04-26T22:11:42Z

I have added silent mode to py_compile.

https://bugs.python.org/issue22640

berkerpeksag

Please wait for @brettcannon's feedback before addressing my review comments. I opened bpo-22640 years ago and unfortunately I forgot to add Brett to nosy list.

berkerpeksag · 2019-04-26T23:07:03Z


+    def test_quiet(self):
+        bad_coding = os.path.join(os.path.dirname(__file__), 'bad_coding2.py')
+        with support.captured_stderr():


Suggested change

with support.captured_stderr():

with support.captured_stderr() as stderr:

Then we can add something like

self.assertEqual(stderr.getvalue(), '')

to test the quiet option.

Why did you mark this resolved? It still needs to be addressed.

Sorry, I had confused it with @vadmium 's comment .

berkerpeksag · 2019-04-26T23:07:39Z

@@ -0,0 +1 @@
+`py_compile` now supports silent mode.


:func:`py_compile.compile`

And please add "Patch by Your Name.".

This comment is still needs to be addressed as well.

bedevere-bot · 2019-04-26T23:12:13Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ZackerySpytz

Do not use "quite" instead of "quiet", please.

nanjekyejoannah · 2019-04-27T21:38:38Z

Please wait for @brettcannon's feedback before addressing my review comments. I opened bpo-22640 years ago and unfortunately I forgot to add Brett to nosy list.

Noted.

brettcannon · 2019-05-06T18:53:54Z

I'm fine with the idea.

nanjekyejoannah · 2019-05-08T14:40:32Z

Great, I will finish addressing the reviews on this PR as soon as I can.

nanjekyejoannah · 2019-05-10T15:12:02Z

I have made the requested changes; please review again.

bedevere-bot · 2019-05-10T15:12:06Z

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag

This looks good to me, thank you! I just left mostly trivial comments.

You may also want to check documentation changes with a native English speaker. I'm not a native speaker, so they may help us to simply documentation changes :)

bedevere-bot · 2019-05-15T17:38:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

… into issue22640

ZackerySpytz · 2019-05-27T18:13:54Z

@nanjekyejoannah It seems that you marked my comment as "resolved", but the "What's New" entry still falsely states that py_compile.compile is a method. Please fix that.

nanjekyejoannah · 2019-05-27T18:37:31Z

@berkerpeksag PTAL .

nanjekyejoannah · 2019-05-28T15:00:13Z

I have made the requested changes; please review again .

bedevere-bot · 2019-05-28T15:00:21Z

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag · 2019-05-28T16:29:13Z

Thanks!

vstinner · 2019-06-04T12:48:56Z

Well done @nanjekyejoannah!

merwok · 2019-11-15T00:01:54Z

Follow-up in #17134 to fix the NameErrors in main.
As this is already released, 3.7 should get a simple fix and 3.8 the missing part of the feature 🙂

vstinner · 2020-04-30T22:26:12Z

It seems like this change introduced a regression in main(): see https://bugs.python.org/issue40456

merwok · 2020-04-30T22:27:16Z

It seems that you missed my previous message Victor! 🙂

vstinner · 2020-04-30T22:53:42Z

It seems that you missed my previous message Victor! slightly_smiling_face

Oh, right. Well, the main() changes of this PR should be reverted in 3.8. #17134 is new feature which should not into 3.8.

the-knights-who-say-ni added the CLA signed label Apr 26, 2019

bedevere-bot added the awaiting review label Apr 26, 2019

nanjekyejoannah changed the title ~~bpo-22640: Add silent mode for py_compile~~ bpo-22640: Add silent mode to py_compile Apr 26, 2019

berkerpeksag requested changes Apr 26, 2019

View reviewed changes

bedevere-bot removed the awaiting review label Apr 26, 2019

bedevere-bot added the awaiting changes label Apr 26, 2019

berkerpeksag requested a review from brettcannon April 26, 2019 23:12

ZackerySpytz reviewed Apr 27, 2019

View reviewed changes

Comment thread Doc/library/py_compile.rst Outdated

Comment thread Doc/library/py_compile.rst Outdated

tirkarthi reviewed Apr 27, 2019

View reviewed changes

Comment thread Lib/py_compile.py Outdated

Comment thread Lib/py_compile.py Outdated

vadmium reviewed Apr 27, 2019

View reviewed changes

Comment thread Lib/py_compile.py Outdated

Comment thread Lib/test/test_py_compile.py

Comment thread Doc/library/py_compile.rst Outdated

Comment thread Doc/whatsnew/3.8.rst Outdated

nanjekyejoannah force-pushed the issue22640 branch from 44d5270 to 754afeb Compare May 10, 2019 14:49

bedevere-bot added awaiting change review and removed awaiting changes labels May 10, 2019

berkerpeksag requested changes May 15, 2019

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting change review labels May 15, 2019

nanjekyejoannah requested review from 1st1, asvetlov, encukou, ericsnowcurrently, gpshead, gvanrossum and ilevkivskyi as code owners May 17, 2019 17:14

nanjekyejoannah added 3 commits May 27, 2019 12:00

Fix Docs

ee76f31

Merge branch 'issue22640' of https://github.com/nanjekyejoannah/cpython…

696fcca

… into issue22640

Fix Docs

c51cd67

ZackerySpytz reviewed May 27, 2019

View reviewed changes

Comment thread Doc/whatsnew/3.8.rst Outdated

change to func

65afe83

nanjekyejoannah added 2 commits May 27, 2019 15:34

Remove function.

4c55240

Correct grammar

07139d6

bedevere-bot added awaiting change review and removed awaiting changes labels May 28, 2019

berkerpeksag approved these changes May 28, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 28, 2019

berkerpeksag merged commit 2e33ecd into python:master May 28, 2019

bedevere-bot removed the awaiting merge label May 28, 2019

nanjekyejoannah deleted the issue22640 branch May 29, 2019 00:36

merwok mentioned this pull request Dec 3, 2019

bpo-38731: Add --quiet option to py_compile CLI #17134

Merged

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-22640: Add silent mode to py_compile.compile() (pythonGH-12976)

3db9ade

icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Sep 8, 2023

bpo-22640: Add silent mode to py_compile.compile() (pythonGH-12976)

f4ea731

icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Sep 14, 2023

bpo-22640: Add silent mode to py_compile.compile() (pythonGH-12976)

da85b82

icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Sep 27, 2023

bpo-22640: Add silent mode to py_compile.compile() (pythonGH-12976)

7e4cccc

	with support.captured_stderr():
	with support.captured_stderr() as stderr:

		@@ -0,0 +1 @@
		`py_compile` now supports silent mode. No newline at end of file

Uh oh!

Conversation

nanjekyejoannah commented Apr 26, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

berkerpeksag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

berkerpeksag Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

berkerpeksag May 24, 2019

Choose a reason for hiding this comment

Uh oh!

nanjekyejoannah May 24, 2019

Choose a reason for hiding this comment

Uh oh!

berkerpeksag Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

berkerpeksag Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

berkerpeksag May 24, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 26, 2019

Uh oh!

ZackerySpytz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nanjekyejoannah commented Apr 27, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brettcannon commented May 6, 2019

Uh oh!

nanjekyejoannah commented May 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nanjekyejoannah commented May 10, 2019

Uh oh!

bedevere-bot commented May 10, 2019

Uh oh!

berkerpeksag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 15, 2019

Uh oh!

Uh oh!

ZackerySpytz commented May 27, 2019

Uh oh!

nanjekyejoannah commented May 27, 2019

Uh oh!

nanjekyejoannah commented May 28, 2019

Uh oh!

bedevere-bot commented May 28, 2019

Uh oh!

berkerpeksag commented May 28, 2019

nanjekyejoannah commented Apr 26, 2019 •

edited by bedevere-bot

Loading

nanjekyejoannah commented Apr 27, 2019 •

edited by bedevere-bot

Loading

nanjekyejoannah commented May 8, 2019 •

edited

Loading