bpo-38731: Add --quiet option to py_compile CLI by gvsheva · Pull Request #17134 · python/cpython

gvsheva · 2019-11-12T22:02:41Z

Fixing missed quiet variable in py_compile.py module.

https://bugs.python.org/issue40456

the-knights-who-say-ni · 2019-11-12T22:02:45Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@gvsheva

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

brandtbucher · 2019-11-13T01:37:05Z

Thanks for your time @gvsheva, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

brandtbucher

I'm not sure about this solution.

I don't see that passing -q from the command line is actually documented anywhere, and it would be the only argument that we parse out like this.

It probably makes the most sense to just remove the branching below that references quiet and just always write the error messages.

brandtbucher · 2019-11-13T01:48:38Z

This PR should also have a NEWS entry. Just something simple, like:

Fix a crash during error handling in :meth:`py_compile.main`.

gvsheva · 2019-11-13T08:53:21Z

All was done, but I can't understand why Travis CI build was failed.

brandtbucher · 2019-11-13T19:45:07Z

@gvsheva It looks like an issue on Travis's end, unrelated to your changes. Pushing to your branch or closing-and-reopening this PR (not making a new one) should re-trigger the build.

brandtbucher

Looks good now!

merwok · 2019-11-14T18:09:44Z

I think that the original intent was to support setting quiet mode on the command line. IMO this PR should be accepted to fix 3.8, but the original feature should be completed on master branch. Could you notify the original issue about this?

gvsheva · 2019-11-14T20:52:50Z

The original issue is https://bugs.python.org/issue22640

merwok · 2019-11-15T00:00:57Z

Yes, can you add a comment there?

Co-Authored-By: Éric Araujo <[email protected]>

merwok · 2019-11-16T20:41:25Z

@berkerpeksag do you agree with me?

I think that the original intent was to support setting quiet mode on the command line. IMO this PR should be accepted to fix 3.8, but the original feature should be completed on master branch.

pablogsal

Hi @gvsheva and thanks for your contribution, could you add a test case for this in the test suite? Thanks!

gvsheva · 2020-07-16T15:28:25Z

I have made the requested changes; please review again.

bedevere-bot · 2020-07-16T15:28:30Z

Thanks for making the requested changes!

@merwok, @nanjekyejoannah, @pablogsal, @berkerpeksag: please review the changes made to this pull request.

berkerpeksag · 2020-07-25T15:15:38Z

I'll make some trivial changes (such as replacing 3.9 with 3.10) to avoid keeping this unmerged any longer and then merge, thanks!

berkerpeksag

This is now ready to go. I've made some adjustments to tests (no need to run them twice) and other random tweaks. I've also made sure that tests are passed without porting CLI to argparse (minus tests related to the --quiet option, of course) I'll submit another PR to fix the regression in 3.8 and 3.9.

berkerpeksag · 2020-07-25T19:59:08Z

Thank you!

bedevere-bot · 2020-07-25T20:22:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO + PGO 3.x has failed when building commit daff390.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/483/builds/857) and take a look at the build logs.
Check if the failure is related to this commit (daff390) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/483/builds/857

Failed tests:

test_nntplib

Failed subtests:

test_with_statement - test.test_nntplib.NetworkedNNTP_SSLTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

test_peg_generator: 3 min 23 sec
test_concurrent_futures: 3 min 16 sec
test_tokenize: 1 min 32 sec
test_multiprocessing_spawn: 1 min 27 sec
test_unparse: 1 min 17 sec
test_multiprocessing_forkserver: 1 min 10 sec
test_lib2to3: 1 min 10 sec
test_asyncio: 1 min 3 sec
test_multiprocessing_fork: 58.3 sec
test_signal: 48.6 sec

1 test failed:
test_nntplib

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 6 min 47 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_nntplib.py", line 277, in test_with_statement
    server = self.NNTP_CLASS(self.NNTP_HOST,
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 1025, in __init__
    super().__init__(host, port, user, password, readermode,
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 334, in __init__
    self.sock = self._create_socket(timeout)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 1031, in _create_socket
    sock = _encrypt_on(sock, self.ssl_context, self.host)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/nntplib.py", line 292, in _encrypt_on
    return context.wrap_socket(sock, server_hostname=hostname)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1121)


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_nntplib.py", line 293, in test_with_statement
    if re.search(r'(?i)KEY.TOO.SMALL', ssl_err.reason):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object

bedevere-bot · 2020-07-25T20:31:20Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.x has failed when building commit daff390.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/527/builds/856) and take a look at the build logs.
Check if the failure is related to this commit (daff390) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/527/builds/856

Failed tests:

test_nntplib

Failed subtests:

test_with_statement - test.test_nntplib.NetworkedNNTP_SSLTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 12 sec
test_peg_generator: 2 min 47 sec
test_multiprocessing_spawn: 1 min 39 sec
test_tokenize: 1 min 36 sec
test_unparse: 1 min 26 sec
test_asyncio: 1 min 15 sec
test_lib2to3: 1 min 8 sec
test_multiprocessing_forkserver: 1 min 7 sec
test_multiprocessing_fork: 57.5 sec
test_signal: 47.9 sec

1 test failed:
test_nntplib

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 7 min 6 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 293, in test_with_statement
    if re.search(r'(?i)KEY.TOO.SMALL', ssl_err.reason):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_nntplib.py", line 277, in test_with_statement
    server = self.NNTP_CLASS(self.NNTP_HOST,
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 1025, in __init__
    super().__init__(host, port, user, password, readermode,
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 334, in __init__
    self.sock = self._create_socket(timeout)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 1031, in _create_socket
    sock = _encrypt_on(sock, self.ssl_context, self.host)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/nntplib.py", line 292, in _encrypt_on
    return context.wrap_socket(sock, server_hostname=hostname)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1121)

bpo-38731: add missing quiet variable in py_compile.main

241a633

the-knights-who-say-ni added the CLA not signed label Nov 12, 2019

bedevere-bot added the awaiting review label Nov 12, 2019

brandtbucher added the type-bug An unexpected behavior, bug, or error label Nov 13, 2019

brandtbucher requested changes Nov 13, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Nov 13, 2019

📜🤖 Added by blurb_it.

5c4b7dd

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Nov 13, 2019

bpo-38731: remove undefined quiet variable from py_compile.main

94ee0c7

gvsheva changed the title ~~bpo-38731: add missing quiet variable in py_compile.main~~ bpo-38731: fix missing quiet variable in py_compile.main Nov 13, 2019

brandtbucher approved these changes Nov 13, 2019

View reviewed changes

gvsheva closed this Nov 14, 2019

gvsheva reopened this Nov 14, 2019

merwok reviewed Nov 14, 2019

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2019-11-13-07-37-11.bpo-38731.9qmcSx.rst Outdated

bpo-38731: fix NEWS entry

6a7c446

merwok reviewed Nov 14, 2019

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2019-11-13-07-37-11.bpo-38731.9qmcSx.rst Outdated

merwok mentioned this pull request Nov 15, 2019

bpo-22640: Add silent mode to py_compile #12976

Merged

Update Misc/NEWS.d/next/Library/2019-11-13-07-37-11.bpo-38731.9qmcSx.rst

4466105

Co-Authored-By: Éric Araujo <[email protected]>

pablogsal requested changes Nov 21, 2019

View reviewed changes

gvsheva closed this Jul 15, 2020

gvsheva reopened this Jul 15, 2020

gvsheva closed this Jul 16, 2020

gvsheva reopened this Jul 16, 2020

merwok requested a review from nanjekyejoannah July 16, 2020 14:27

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 16, 2020

berkerpeksag added 5 commits July 25, 2020 19:44

Tweaks before merge

51f05df

debug stdin test on windows

6df8c07

avoid BytesWarning

ae5752e

rework cli tests a bit

8235543

Merge remote-tracking branch 'upstream/master' into pr/17134

400a4e2

berkerpeksag changed the title ~~bpo-40456: add quiet mode for py_compile main~~ bpo-38731: Add --quiet option to py_compile CLI Jul 25, 2020

revert debug output and add more tweaks

024f402

berkerpeksag approved these changes Jul 25, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jul 25, 2020

berkerpeksag merged commit daff390 into python:master Jul 25, 2020

bedevere-bot removed the awaiting merge label Jul 25, 2020

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020

bpo-38731: Add --quiet option to py_compile CLI (pythonGH-17134)

b9063e5

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020

bpo-38731: Add --quiet option to py_compile CLI (pythonGH-17134)

6be96d8

duncanmmacleod mentioned this pull request Sep 21, 2020

Python 3.9.0rc recipe conda-forge/python-feedstock#389

Merged

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-38731: Add --quiet option to py_compile CLI (pythonGH-17134)

42abade

Uh oh!

Conversation

gvsheva commented Nov 12, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Nov 12, 2019

CLA Missing

Uh oh!

brandtbucher commented Nov 13, 2019

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

brandtbucher commented Nov 13, 2019

Uh oh!

gvsheva commented Nov 13, 2019

Uh oh!

brandtbucher commented Nov 13, 2019

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

merwok commented Nov 14, 2019

Uh oh!

gvsheva commented Nov 14, 2019

Uh oh!

Uh oh!

merwok commented Nov 15, 2019

Uh oh!

merwok commented Nov 16, 2019

Uh oh!

pablogsal left a comment

Choose a reason for hiding this comment

Uh oh!

gvsheva commented Jul 16, 2020

Uh oh!

bedevere-bot commented Jul 16, 2020

Uh oh!

berkerpeksag commented Jul 25, 2020

Uh oh!

berkerpeksag left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

berkerpeksag commented Jul 25, 2020

Uh oh!

bedevere-bot commented Jul 25, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Jul 25, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gvsheva commented Nov 12, 2019 •

edited by bedevere-bot

Loading

berkerpeksag left a comment •

edited

Loading