gh-136355: Deprecate -b and -bb CLI flags in 3.15#136363
gh-136355: Deprecate -b and -bb CLI flags in 3.15#136363sobolevn merged 8 commits intopython:mainfrom
-b and -bb CLI flags in 3.15#136363Conversation
StanFromIreland
left a comment
There was a problem hiding this comment.
This should be added to pending-removal-in-3.17.rst?
Also, -bb is not documented and must be unliked/escaped (I don't know what to call: !) to stop errors.
malemburg
left a comment
There was a problem hiding this comment.
Apart from the wording changes, this LGTM.
|
When you're done making the requested changes, leave the comment: |
vstinner
left a comment
There was a problem hiding this comment.
Can you update the PR to not emit a deprecation warning and not schedule the flag removal?
Can you also deprecate PyConfig.bytes_warning member in the doc? https://docs.python.org/dev/c-api/init_config.html#c.PyConfig.bytes_warning
|
Done! I addressed all feedback: now we no longer plan to remove Please, take another look :) |
|
I don't think we should remove these options anytime soon. Why possibly break code that's using them ? Instead, we could simply remove the documentation and make them no-ops, but still accept them on the command line. |
fc4cda4 to
37efb67
Compare
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
|
FYI bedevere is still waiting for changes: #136363 (comment) |
|
I have made the requested changes; please review again. To please the bot :) |
|
Thanks for making the requested changes! @malemburg: please review the changes made to this pull request. |
|
When you're done making the requested changes, leave the comment: |
malemburg
left a comment
There was a problem hiding this comment.
Sorry, I didn't see the original, just the suggestion. All good now.
|
Thanks everyone! 👍 |
-band-bbCLI flags #136355📚 Documentation preview 📚: https://cpython-previews--136363.org.readthedocs.build/