Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable#1887
Closed
pitrou wants to merge 1 commit intopython:masterfrom
Closed
Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable#1887pitrou wants to merge 1 commit intopython:masterfrom
pitrou wants to merge 1 commit intopython:masterfrom
Conversation
…writable This simplifies the reconfiguration of standard streams as it can now be done in-place.
|
@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @birkenfeld to be potential reviewers. |
Member
Author
|
The AppVeyor failure is unrelated. |
benjaminp
reviewed
Jun 1, 2017
Contributor
benjaminp
left a comment
There was a problem hiding this comment.
so what happens when I set line_buffering = True and write_through = True?
| @@ -908,6 +908,16 @@ Text I/O | |||
|
|
|||
| Whether line buffering is enabled. | |||
Contributor
There was a problem hiding this comment.
should also say that writing to it flushes the stream
| .. attribute:: write_through | ||
|
|
||
| Whether writes are passed immediately to the underlying binary | ||
| buffer. This argument is writable. |
Member
Author
|
#1922 is now preferred. |
Member
Author
Same as before: |
Member
Author
|
Superseded by #1922. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the reconfiguration of standard streams as it can now be done in-place.