bpo-41730: Show deprecation warnings for tkinter.tix by wyz23x2 · Pull Request #22186 · python/cpython

wyz23x2 · 2020-09-10T11:24:22Z

The tkinter.tix module has been deprecated since Python 3.6. Warn a DeprecationWarning when importing it.

https://bugs.python.org/issue41730

wyz23x2 · 2020-09-10T11:49:27Z

All tests have passed. Now it's time to merge!

E-Paine

Good spot with the example (lines 16 + 17) 👍
Your PR still shows in issue 41370
The doc (https://docs.python.org/3/library/tkinter.tix.html) states "This Tk extension is unmaintained and should not be used in new code.".

Apologies, I missed that.

@E-Paine

Suggested by @E-Paine Co-authored-by: E-Paine <[email protected]>

wyz23x2 · 2020-09-10T11:53:34Z

Has been removed from bpo-41370. Thanks!

E-Paine · 2020-09-10T11:57:49Z

Has been removed from bpo 41370. Thanks!

Um... Not sure if this is because of bedevere on your last comment, but it has reappeared there (may just be worth leaving it for someone else to sort out...)

wyz23x2 · 2020-09-10T11:58:26Z

😓

wyz23x2 · 2020-09-10T11:58:59Z

Is it OK now? https://bugs.python.org/issue41370?@ok_message=issue%2041370%20pull_requests%20edited%20ok&@template=item

E-Paine · 2020-09-10T12:00:58Z

It appears so 😄 (EDIT: Appears like its fixed rather than its still there - sorry for the lack of clarity)

wyz23x2 · 2020-09-10T12:03:51Z

🆗! Thanks!

wyz23x2 · 2020-09-10T12:05:53Z

IMO the tracker shouldn't link again if it was unlinked before 😄

wyz23x2 · 2021-03-16T11:57:53Z

Um, is there any further process on this?

bedevere-bot · 2021-03-16T15:08:26Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Zachary Ware <[email protected]>

bedevere-bot · 2021-05-07T15:12:15Z

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

bedevere-bot · 2021-05-07T15:33:50Z

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

E-Paine · 2021-05-07T15:34:38Z

You also need to change line 32 to use import_helper

E-Paine · 2021-05-07T15:38:56Z

I believe we should keep the import _tkinter (in tix.py) as it reduces the length of the traceback (if tkinter fails to load for whatever reason).

E-Paine · 2021-05-07T15:40:22Z

Actually, it was redundant where it was. So we should probably move it before the main tkinter import or remove it (as you have done).

miss-islington · 2021-05-07T15:53:26Z

Thanks @wyz23x2 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot · 2021-05-07T15:53:48Z

GH-25971 is a backport of this pull request to the 3.10 branch.

Co-authored-by: E-Paine <[email protected]> Co-authored-by: Zachary Ware <[email protected]> (cherry picked from commit 4a2d98a) Co-authored-by: wyz23x2 <[email protected]>

pablogsal · 2021-05-09T04:16:35Z

Unfortunately this commit has introduced some reference leaks, see:

https://buildbot.python.org/all/#/builders/684/builds/5

@zware could you take a look?

Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks. The test isn't worth hunting them down, so it's simply reverted. This partially reverts commit 4a2d98a.

zware · 2021-05-09T06:44:35Z

~~The linked failure doesn't appear to have anything to do with Tix, and in fact the next build (not yet finished, on its last test) appears to be fine.~~

Ah, you mean https://buildbot.python.org/all/#/builders/511/builds/23 :). The test isn't worthwhile; I've opened GH-26005 to revert it.

Added in bpo-41730 (GH-22186), the test apparently causes refleaks. The test isn't worth hunting them down, so it's simply reverted. This partially reverts commit 4a2d98a.

Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks. The test isn't worth hunting them down, so it's simply reverted. This partially reverts commit 4a2d98a. (cherry picked from commit 8e8307d) Co-authored-by: Zachary Ware <[email protected]>

Added in bpo-41730 (GH-22186), the test apparently causes refleaks. The test isn't worth hunting them down, so it's simply reverted. This partially reverts commit 4a2d98a. (cherry picked from commit 8e8307d) Co-authored-by: Zachary Ware <[email protected]>

pablogsal · 2021-05-09T14:57:15Z

Ah, you mean https://buildbot.python.org/all/#/builders/511/builds/23 :). The test isn't worthwhile; I've opened GH-26005 to revert it.

My bad! I copied the wrong url :(

wyz23x2 added 3 commits September 10, 2020 19:08

bpo-41730: Show deprecation warnings for tkinter.tix

32e8c9c

bpo-41730: Show deprecation warnings for tkinter.tix

897b604

bpo-41730: Show deprecation warnings for tkinter.tix

ce41fbe

the-knights-who-say-ni added the CLA signed label Sep 10, 2020

bedevere-bot added the awaiting review label Sep 10, 2020

bpo-41730: Show deprecation warnings for tkinter.tix

21f0799

wyz23x2 changed the title ~~bpo-41370: Show deprecation warnings for tkinter.tix~~ bpo-41730: Show deprecation warnings for tkinter.tix Sep 10, 2020

E-Paine reviewed Sep 10, 2020

View reviewed changes

Comment thread Lib/tkinter/tix.py Outdated

bpo-41730: Show deprecation warnings for tkinter.tix

44565df

Suggested by @E-Paine Co-authored-by: E-Paine <[email protected]>

This comment has been minimized.

Sign in to view

E-Paine approved these changes Sep 10, 2020

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Sep 10, 2020

wyz23x2 mentioned this pull request Sep 10, 2020

Don't link PR to bpo again if unlinked before python/bugs.python.org#54

Closed

terryjreedy requested a review from serhiy-storchaka September 10, 2020 19:14

zware requested changes Mar 16, 2021

View reviewed changes

Comment thread Lib/tkinter/tix.py Outdated

Comment thread Misc/NEWS.d/next/Library/2020-09-10-07-23-24.bpo-41730.DyKFi9.rst Outdated

Comment thread Lib/tkinter/tix.py Outdated

Comment thread Lib/tkinter/tix.py Outdated

bedevere-bot removed the awaiting core review label Mar 16, 2021

bedevere-bot added the awaiting changes label Mar 16, 2021

wyz23x2 and others added 2 commits March 17, 2021 19:41

Update Misc/NEWS.d/next/Library/2020-09-10-07-23-24.bpo-41730.DyKFi9.rst

97b6ff1

Co-authored-by: Zachary Ware <[email protected]>

Update Lib/tkinter/tix.py

e2767f5

Co-authored-by: Zachary Ware <[email protected]>

bedevere-bot added the awaiting change review label May 7, 2021

bedevere-bot requested a review from zware May 7, 2021 15:12

Update test_tix.py

ca233ab

Cleanups

9602a7c

zware approved these changes May 7, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 7, 2021

zware added the needs backport to 3.10 only security fixes label May 7, 2021

zware merged commit 4a2d98a into python:main May 7, 2021

bedevere-bot removed the awaiting merge label May 7, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label May 7, 2021

wyz23x2 deleted the patch-5 branch May 7, 2021 16:06

zware mentioned this pull request May 9, 2021

Revert test for Tix deprecation warning #26005

Merged

miss-islington mentioned this pull request May 9, 2021

[3.10] Revert test for Tix deprecation warning (GH-26005) #26006

Merged

pablogsal mentioned this pull request Jul 18, 2021

[3.10] Correct the order of regen-abidump #27228

Closed

Uh oh!

Conversation

wyz23x2 commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wyz23x2 commented Sep 10, 2020

Uh oh!

E-Paine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wyz23x2 commented Sep 10, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

E-Paine commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wyz23x2 commented Sep 10, 2020

Uh oh!

wyz23x2 commented Sep 10, 2020

Uh oh!

E-Paine commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

wyz23x2 commented Sep 10, 2020

Uh oh!

wyz23x2 commented Sep 10, 2020

Uh oh!

wyz23x2 commented Mar 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 16, 2021

Uh oh!

bedevere-bot commented May 7, 2021

Uh oh!

bedevere-bot commented May 7, 2021

Uh oh!

E-Paine commented May 7, 2021

Uh oh!

E-Paine commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

E-Paine commented May 7, 2021

Uh oh!

miss-islington commented May 7, 2021

Uh oh!

bedevere-bot commented May 7, 2021

Uh oh!

pablogsal commented May 9, 2021

Uh oh!

zware commented May 9, 2021

Uh oh!

pablogsal commented May 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wyz23x2 commented Sep 10, 2020 •

edited

Loading

wyz23x2 commented Sep 10, 2020 •

edited by bedevere-bot

Loading

E-Paine commented Sep 10, 2020 •

edited

Loading

E-Paine commented Sep 10, 2020 •

edited

Loading

E-Paine commented May 7, 2021 •

edited

Loading