Skip to content

Revert test for Tix deprecation warning#26005

Merged
zware merged 1 commit intopython:mainfrom
zware:revert_tix_deprecation_test
May 9, 2021
Merged

Revert test for Tix deprecation warning#26005
zware merged 1 commit intopython:mainfrom
zware:revert_tix_deprecation_test

Conversation

@zware
Copy link
Copy Markdown
Member

@zware zware commented May 9, 2021

Added in bpo-41730 (GH-22186), the test apparently causes refleaks. The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.

Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks.  The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.
@zware zware self-assigned this May 9, 2021
@zware zware requested a review from pablogsal May 9, 2021 06:44
@zware zware merged commit 8e8307d into python:main May 9, 2021
@zware zware deleted the revert_tix_deprecation_test branch May 9, 2021 06:58
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry @zware, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e8307d70bb9dc18cfeeed3277c076309b27515e 3.10

@zware zware added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels May 9, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-26006 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2021
Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks.  The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.
(cherry picked from commit 8e8307d)

Co-authored-by: Zachary Ware <[email protected]>
miss-islington added a commit that referenced this pull request May 9, 2021
Added in bpo-41730 (GH-22186), the test apparently causes refleaks.  The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.
(cherry picked from commit 8e8307d)

Co-authored-by: Zachary Ware <[email protected]>
@pablogsal
Copy link
Copy Markdown
Member

Thanks @zware !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants